Added system setup instructions + fixed bug in bug.py:info #29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lation process + fixed bug in bug.py:info (Python was complaining about backslash in f-string)
Nfsaavedra
requested changes
Jul 10, 2024
Contributor
Nfsaavedra
left a comment
Nfsaavedra
left a comment
There was a problem hiding this comment.
Thank you for this PR! The information you added to the README is very helpful. I just added suggestions to fix some typos.
Nfsaavedra
reviewed
Jul 10, 2024
Nfsaavedra
approved these changes
Jul 10, 2024
Contributor
|
I ended up just fixing the typos. I'll merge now. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Clarify README instructions: while trying to reproduce the setup, I faced problems with some implicit requirements that were not mentioned. I thought adding hints about it in the README would help future users (though the experience might differ depending on the initial environment).
2. Fixed bug: Python3.11 complains about backslash in f-string at bug.py:info:342. I added a quick fix and also split the result of multiple failing tests by adding new line. Single quotes were mixed with double quotes inside double quotes. I replaced the inner double quotes with single ones.